Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Road crosses Road" warnings disappear even when not resolved #10671

Open
DujaOSM opened this issue Jan 10, 2025 · 2 comments
Open

"Road crosses Road" warnings disappear even when not resolved #10671

DujaOSM opened this issue Jan 10, 2025 · 2 comments
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code

Comments

@DujaOSM
Copy link

DujaOSM commented Jan 10, 2025

URL

https://tools.geofabrik.de/osmi/?view=routing&lon=20.45357&lat=44.54193&zoom=13&baselayer=Geofabrik%20Standard&overlays=unconnected_open_ends_1

How to reproduce the issue?

No response

Screenshot(s) or anything else?

RoadXRoad

  1. Create a section of e.g. Tertiary Road connected to an existing road
  2. Create 3 sections of e.g. Residential Roads connected to it, as in the screenshot
  3. Select the Tertiary road and [D]isconnect it from everything. "Residential Road is very close to Tertiary" and "Residential Road crosses Tertiary" appear 3 times each, as expected.
  4. Select one warning and resolve it by "Connect the features"
  5. All other warnings now disappear without being resolved (there aren't warnings for the two bottom roads anymore).

You can re-trigger validation for one road by e.g. slightly moving its point, but you have to know it is invalid in the first place.

Background: I was cleaning up a rather large area by disconnecting roads from landuse, counting on iD to warn me on (near-)crossings and offer reconnecting roads to roads. Since it mostly didn't, I created over 50 routing errors in e.g. changeset 161131307.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Firefox

@ratrun
Copy link

ratrun commented Jan 10, 2025

Please note that the provided URL at the top will stop showing the errors soon as they are going to be fixed. Therefore here is screenshot as it looks today:
image

@tyrasd tyrasd added the validation An issue with the validation or Q/A code label Jan 14, 2025
@tyrasd
Copy link
Member

tyrasd commented Jan 14, 2025

Yeah, there seems to be something odd going on: When I tried to replicate the bug, I noticed that for some of the disconnected nodes there are no warnings shown at all. 🤔 Apparently, iD does currently not reliably find situations where two roads meet at nodes with different node id, but the same coordinates

@tyrasd tyrasd added the bug A bug - let's fix this! label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants