Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate presets for amenity=charging_station (for bicycle=yes and motorcar=yes) #1107

Closed

Conversation

qugebert
Copy link
Contributor

@qugebert qugebert commented Feb 7, 2024

See #1085 (comment)

This adds two presets for charging stations depending on the vehicle they are intended for.

Copy link

github-actions bot commented Feb 7, 2024

🍱 You can preview the tagging presets of this pull request here.

@tyrasd
Copy link
Member

tyrasd commented Feb 14, 2024

Hey, thanks for the PR. Unfortunately, when suggesting this in my comment, I forgot about one thing: The way the preset matches OSM objects makes it such that these two presets would apply to not only the single-vehicle-type sites we would want it to apply to (e.g. amenity=charging_station + bicycle=yes), but also to multiple-vehicle-type sites where a partial match exists (e.g. amenity=charging_station + bicycle=yes + motorcycle=yes, etc.).

So, for now this does not work in the tagging schema (see ideditor/schema-builder#25 for a suggestion to fix this, potentially). I'm really sorry for not thinking about this in the first place! 🙇

@tyrasd tyrasd closed this Feb 14, 2024
@qugebert
Copy link
Contributor Author

Hey, thanks for the PR. Unfortunately, when suggesting this in my comment, I forgot about one thing: The way the preset matches OSM objects makes it such that these two presets would apply to not only the single-vehicle-type sites we would want it to apply to (e.g. amenity=charging_station + bicycle=yes), but also to multiple-vehicle-type sites where a partial match exists (e.g. amenity=charging_station + bicycle=yes + motorcycle=yes, etc.).

Oh, is see. This would be kinda confusing.

I'm really sorry for not thinking about this in the first place! 🙇

It's fine. I'm still learning how this projects works and with that I also learned a little bit about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants