fix: clicking node in the outline tree is invalid when page unlocked

[gene9831]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

历史代码遗留问题：当页面未锁定时，大纲树点击节点后，画布中不显示选中的节点
交互更改为：页面即使未锁定，大纲树点击或者悬停节点后，画布中显示选中的节点。因为点击或者悬停节点并没有对页面schema进行修改，所以这个动作是允许的

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Improved the responsiveness of interactive elements so that mouse hover and click actions now consistently trigger the expected behavior, ensuring a smoother user experience.

[coderabbitai]

Walkthrough

This change removes the conditional checks on state.isLock in the handleMouseEnterRow and handleClickRow functions of the Tree plugin’s Main.vue file. As a result, the event handlers now always execute their logic regardless of the lock state, modifying the control flow within these functions.

Changes

File	Change Summary
packages/.../Main.vue	Removed conditional checks for state.isLock in both handleMouseEnterRow and handleClickRow functions.

Sequence Diagram(s)

sequenceDiagram
    participant UI as User Interface
    participant Main as Main.vue
    participant Handler as Event Handler

    UI->>Main: Trigger mouseenter/click event
    Main->>Handler: Invoke handleMouseEnterRow/handleClickRow
    Handler-->>Main: Execute event logic (bypass state.isLock check)

Loading

Possibly related PRs

• feat: outline tree support dragging #1050: Introduces similar event handling modifications in the DraggableTree component, indicating a direct link in controlling mouse events.

Suggested labels

bug

Suggested reviewers

• chilingling
• rhlin

Poem

I am a rabbit, quiet and keen,
Hopping through lines in a digital scene.
Removed the lock that slowed the flow,
Now clicks and hovers freely go.
With a twitch of my whiskers, I celebrate the code anew.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d931aea and d250af5.

📒 Files selected for processing (1)

• packages/plugins/tree/src/Main.vue (0 hunks)

💤 Files with no reviewable changes (1)

• packages/plugins/tree/src/Main.vue

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.