Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop time fetching in added or replacement trips #6245

Open
wants to merge 14 commits into
base: dev-2.x
Choose a base branch
from

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Nov 8, 2024

Summary

This fixes problems when reading stop times for added or replacement trips.

The logic of fetching trip times is moved into TransitService. The list is optional because it can be empty if the trip doesn't run at all on a specified date (in contrast, an empty list would theoretically mean that the trip does run on the date, but it doesn't make any call for the whole journey).

Also, the behaviour of invalid date is changed to produce an error instead of returning null silently in the GTFS GraphQL API, since null is a valid return value meaning the trip doesn't run.

Issue

Fixes #6088
Fixes #6242

Unit tests

Unit tests are added into TransitService for the new methods, for both existing and added trips.

GraphQL Integration tests are added for one added trip and one replacement trip. This is the first time real-time updates can be integration tested.

Documentation

None needed

@miklcct miklcct requested a review from a team as a code owner November 8, 2024 15:52
@miklcct miklcct force-pushed the fix-departureArrivalStopTime-npe branch from 36ef65d to ed3bb9b Compare November 8, 2024 15:53
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 66.19718% with 24 lines in your changes missing coverage. Please review.

Project coverage is 69.83%. Comparing base (cda3595) to head (a7dc78e).
Report is 58 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...java/org/opentripplanner/model/TripTimeOnDate.java 27.27% 2 Missing and 6 partials ⚠️
...entripplanner/apis/gtfs/datafetchers/TripImpl.java 87.09% 3 Missing and 1 partial ⚠️
...model/model/timetable/DatedServiceJourneyType.java 0.00% 4 Missing ⚠️
...transmodel/model/timetable/ServiceJourneyType.java 20.00% 4 Missing ⚠️
...planner/transit/service/DefaultTransitService.java 80.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6245      +/-   ##
=============================================
+ Coverage      69.71%   69.83%   +0.11%     
- Complexity     17662    17725      +63     
=============================================
  Files           2007     2007              
  Lines          75647    75807     +160     
  Branches        7741     7762      +21     
=============================================
+ Hits           52741    52943     +202     
+ Misses         20190    20146      -44     
- Partials        2716     2718       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miklcct miklcct force-pushed the fix-departureArrivalStopTime-npe branch 3 times, most recently from 428a549 to df345c2 Compare November 8, 2024 16:08
@miklcct miklcct force-pushed the fix-departureArrivalStopTime-npe branch from 39ca3c3 to d3d283f Compare November 14, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants