-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stop time fetching in added or replacement trips #6245
Open
miklcct
wants to merge
14
commits into
opentripplanner:dev-2.x
Choose a base branch
from
Jnction:fix-departureArrivalStopTime-npe
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix stop time fetching in added or replacement trips #6245
miklcct
wants to merge
14
commits into
opentripplanner:dev-2.x
from
Jnction:fix-departureArrivalStopTime-npe
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklcct
force-pushed
the
fix-departureArrivalStopTime-npe
branch
from
November 8, 2024 15:53
36ef65d
to
ed3bb9b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6245 +/- ##
=============================================
+ Coverage 69.71% 69.83% +0.11%
- Complexity 17662 17725 +63
=============================================
Files 2007 2007
Lines 75647 75807 +160
Branches 7741 7762 +21
=============================================
+ Hits 52741 52943 +202
+ Misses 20190 20146 -44
- Partials 2716 2718 +2 ☔ View full report in Codecov by Sentry. |
miklcct
force-pushed
the
fix-departureArrivalStopTime-npe
branch
3 times, most recently
from
November 8, 2024 16:08
428a549
to
df345c2
Compare
miklcct
force-pushed
the
fix-departureArrivalStopTime-npe
branch
from
November 8, 2024 16:12
df345c2
to
38c3a5a
Compare
It has nothing to do with routing and belongs to the wrong package
better to let error propagate
it can be empty if the trip doesn't run at all
miklcct
force-pushed
the
fix-departureArrivalStopTime-npe
branch
from
November 14, 2024 18:32
39ca3c3
to
d3d283f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes problems when reading stop times for added or replacement trips.
The logic of fetching trip times is moved into
TransitService
. The list is optional because it can be empty if the trip doesn't run at all on a specified date (in contrast, an empty list would theoretically mean that the trip does run on the date, but it doesn't make any call for the whole journey).Also, the behaviour of invalid date is changed to produce an error instead of returning
null
silently in the GTFS GraphQL API, sincenull
is a valid return value meaning the trip doesn't run.Issue
Fixes #6088
Fixes #6242
Unit tests
Unit tests are added into
TransitService
for the new methods, for both existing and added trips.GraphQL Integration tests are added for one added trip and one replacement trip. This is the first time real-time updates can be integration tested.
Documentation
None needed