-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: drop obsoleted and exotic AVX512F #444
Comments
I suggest that you keep both. What you see in any one relbench is mostly noise, but you do also see a ~2% reduction in geometric mean. Looking at the code, I see AVX512BW adds more optimal endianness conversion, which probably speeds up SIMD SHA somewhat - not enough to be seen among formats that became 10% slower, but perhaps enough for a few percent. We also check for AVX512BW as a heuristic in Finally, I think for AVX512F we don't have |
Thinking the other way around: is the
CPUs that people buy (or that exist in some cloud)? Both binaries are necessary? |
If you do insist on dropping one of these, then drop AVX512F. This will exclude 2nd gen Xeon Phi support (or cause a fallback to AVX2 in our binary builds), but those are obsoleted and exotic enough that the few people who still have them will generally make their own builds from source. Current Intel CPUs either have AVX512BW or don't have any AVX-512. For future Intel CPUs, the separation isn't going to be across the F vs. BW axis anyway, but rather across 256-bit vs. 512-bit support within AVX10, which we aren't fully prepared for anyway. https://www.tomshardware.com/news/intels-new-avx10-brings-avx-512-capabilities-to-e-cores |
Drop the obsolete and exotic AVX512F. Current Intel CPUs either have AVX512BW or don't have any AVX-512. For future Intel CPUs, the separation isn't going to be across the F vs. BW. Close #444. Signed-off-by: Claudio André <[email protected]>
Drop the obsolete and exotic AVX512F. Current Intel CPUs either have AVX512BW or don't have any AVX-512. For future Intel CPUs, the separation isn't going to be across the F vs. BW. Close #444. Signed-off-by: Claudio André <[email protected]>
Description
I would say no (but I have little information). So, I compared nonOMP builds of commit 9950d782a7c6e3cf3184e163b706779bb15d8afd (see
Additional Context
below):More investigation is desirable, but is there any reason to maintain two binaries for AVX512? I don't see any.
That said, I plan to
remove one of the AVX512 binaries
. Probably AVX512BW binaries. They offer (basically) the same performance, at the end of the day.Alternatives Considered
Additional Context
A new run:
1.txt
2.txt
The text was updated successfully, but these errors were encountered: