Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: enable AES-NI on packages #634

Closed
claudioandre-br opened this issue Nov 19, 2024 · 1 comment
Closed

[FEAT]: enable AES-NI on packages #634

claudioandre-br opened this issue Nov 19, 2024 · 1 comment
Labels
binaries Binaries will be impacted good first issue Good for newcomers needs-upstream-help Upstream needs to do something to fix this

Comments

@claudioandre-br
Copy link
Member

claudioandre-br commented Nov 19, 2024 •
edited
Loading

Description

See openwall/john#4314

Current situation:

  • I'm not sure on Windows. The package may already be installed.

Alternatives Considered

No response

Additional Context

We need something to show us if AES-NI will be used or not (to be sure it is working).
@claudioandre-br claudioandre-br added good first issue Good for newcomers binaries Binaries will be impacted needs-upstream-help Upstream needs to do something to fix this labels Nov 19, 2024
@claudioandre-br claudioandre-br mentioned this issue Nov 24, 2024
Merged
6 tasks
@claudioandre-br claudioandre-br changed the title [FEAT]: enable AES-NI on non-Linux [FEAT]: enable AES-NI on packages Nov 28, 2024
@claudioandre-br
Copy link
Member Author

Done

claudioandre-br added a commit that referenced this issue Nov 29, 2024
@claudioandre-br
revert: ci: enable AES-NI using yasm (#666)
2e73429 
This reverts commit b6f0254.

Upstream now supports AES-NI (Intel) and AES-CE (ARM, including
Apple Silicon) and does not depend on yasm as it's written in C with
intrinsics.

So I'm reverting #657.

Fix: #634.

Signed-off-by: Claudio André <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binaries Binaries will be impacted good first issue Good for newcomers needs-upstream-help Upstream needs to do something to fix this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@claudioandre-br