Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from prettier + eslint to Biome #2145

Open
1 task
TimoGlastra opened this issue Jan 16, 2025 · 4 comments
Open
1 task

Switch from prettier + eslint to Biome #2145

TimoGlastra opened this issue Jan 16, 2025 · 4 comments

Comments

@TimoGlastra
Copy link
Contributor

Example of setup can be found here: https://github.com/openwallet-foundation-labs/oid4vc-ts/blob/main/biome.json

https://github.com/openwallet-foundation-labs/oid4vc-ts/blob/main/package.json#L14-L15

Things to consider:

Wait for all big PRs that are open to be merged?

@genaris
Copy link
Contributor

genaris commented Jan 27, 2025

Everything that helps to improve CI performance will be well received, and certainly eslint is getting very, very slow since some time. I don't have experience with Biome but I think we could give a try.

@berendsliedrecht
Copy link
Contributor

Basically all projects I start now use Biome and i strongly prefer it over prettier+eslint. It does not require 10 plugins for everything to work, it is insanely fast and way easier to configure.

I think we can introduce it with just the config some rules off. And slowly in following PRs turn each rule on with the fixes. Might be a nicer review process because of that.

@TimoGlastra
Copy link
Contributor Author

@sairanjit the big didcomm PR got merged, so feel free to take a stab at the biome setup!

@sairanjit
Copy link
Contributor

Sure @TimoGlastra I will pick this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants