Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Notify user about mixed content exception #602

Open
nemesifier opened this issue Jul 11, 2022 · 8 comments
Open

[bug] Notify user about mixed content exception #602

nemesifier opened this issue Jul 11, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@nemesifier
Copy link
Member

If the application is served on HTTPs, but the captive portal login / logout endpoints are served via HTTP, the browser throws a security exception which is not shown to the user and the loading overlay is displayed indefinitely.

It would be a lot better to show the message of the exception in a browser alert and clear the loading overlay.

@nemesifier nemesifier added the bug Something isn't working label Jul 11, 2022
@ujjwalkirti
Copy link

Hello @nemesisdesign sir,
I have noticed that this issue has not been closed for a long time and that no one is working on it. I am interested in working on this issue, could you guide me in solving this one out?

@nemesifier
Copy link
Member Author

@ujjwalkirti go ahead, just send a patch.

@ujjwalkirti
Copy link

Okay, sir.

@ujjwalkirti
Copy link

Hello @nemesisdesign , can you help me reproduce this error?
image
I have setup the project and am able to create new user, login and logout as well.

@nemesifier
Copy link
Member Author

@ujjwalkirti you need to serve the application from HTTPs and have it post the captive portal login to HTTP to replicate this.

@ujjwalkirti
Copy link

Hello sir, I am not able to fully understand what do you mean when you say to serve the application from HTTPS.
I started the client and server using yarn start, and then went to url and changed http to https, but then the page won't load and the following error comes up.
Screenshot from 2023-04-10 03-46-24
Please help me so that I can move forward.

@codesankalp
Copy link
Member

@ujjwalkirti You have to start the dev server on https. You can follow how to start https based dev server from here https://webpack.js.org/configuration/dev-server/#devserver-https

After that use captive portal URLs in the config as http (already there in the config). You will see the error in console as specified in the issue description.

@Kartikeya-09
Copy link

Hello @nemesisdesign , can you help me reproduce this error? image I have setup the project and am able to create new user, login and logout as well.

Hey brother, Can you tell me which terminal command you use to open this page from you vs code because i am unable to do this, It would really helpful for me..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do (general)
Development

No branches or pull requests

4 participants