Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zim-testing-suite in tests #113

Open
rgaudin opened this issue Jul 8, 2021 · 3 comments
Open

Use zim-testing-suite in tests #113

rgaudin opened this issue Jul 8, 2021 · 3 comments
Labels
enhancement New feature or request stale

Comments

@rgaudin
Copy link
Member

rgaudin commented Jul 8, 2021

Our reader tests currently uses test zim files from libkiwix's test folder. While those files are still present, I am not sure what the future is for those so we should switch to the more future-proof, stable and appropriate https://github.com/openzim/zim-testing-suite.
@rgaudin rgaudin added the enhancement New feature or request label Jul 8, 2021
@mgautierfr
Copy link
Collaborator

more future-proof, stable and appropriate openzim/zim-testing-suite.

Future-proof and appropriate yes.
stable... not yet 😉

@rgaudin
Copy link
Member Author

rgaudin commented Jul 8, 2021

OK 😅 Well libkiwix isn't stable either as the example.zim was completely rewritten.

Don't intend to do that soon anyway.

@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Oct 2, 2021
rgaudin added a commit that referenced this issue Mar 1, 2023
@rgaudin
Fixed reader tests for updated upstream ZIM
d972b4a 
Upstream (libkiwix) ZIM file corner_cases.zim has been both renamed and recreaed.

Given the new ZIM has no fulltext index, testing search is now conditional

See:
- kiwix/libkiwix@2e9bec9
- https://github.com/kiwix/libkiwix/blob/main/test/data/create_corner_cases_zim_file

Note: such issues would no happen (or wouldn't be our fault) if we were to implement
#113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgaudin @mgautierfr