From 8aa896a2b0d9a0111aa60640a9f2ede188fc2670 Mon Sep 17 00:00:00 2001 From: Eric Schubert Date: Wed, 17 Apr 2024 14:53:22 +0200 Subject: [PATCH 1/3] Add new icons for xeokit toolbar --- .changeset/poor-ears-begin.md | 5 +++++ .gitignore | 3 +++ icons/op-cursor-rectangle-select-16.svg | 4 ++++ icons/op-cursor-select-16.svg | 5 +++++ icons/op-erase-16.svg | 5 +++++ icons/op-scissors-16.svg | 5 +++++ keywords.json | 4 ++++ 7 files changed, 31 insertions(+) create mode 100644 .changeset/poor-ears-begin.md create mode 100644 icons/op-cursor-rectangle-select-16.svg create mode 100644 icons/op-cursor-select-16.svg create mode 100644 icons/op-erase-16.svg create mode 100644 icons/op-scissors-16.svg diff --git a/.changeset/poor-ears-begin.md b/.changeset/poor-ears-begin.md new file mode 100644 index 000000000..39b38fc50 --- /dev/null +++ b/.changeset/poor-ears-begin.md @@ -0,0 +1,5 @@ +--- +'@openproject/octicons': minor +--- + +Add icons for xeokit toolbar diff --git a/.gitignore b/.gitignore index 69fd04074..84eb3a024 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,9 @@ node_modules vendor Gemfile.lock +# Jetbrains IDE +.idea/ + # Ignore build/export artifacts lib/**/build/ diff --git a/icons/op-cursor-rectangle-select-16.svg b/icons/op-cursor-rectangle-select-16.svg new file mode 100644 index 000000000..024165ffd --- /dev/null +++ b/icons/op-cursor-rectangle-select-16.svg @@ -0,0 +1,4 @@ + + + + diff --git a/icons/op-cursor-select-16.svg b/icons/op-cursor-select-16.svg new file mode 100644 index 000000000..977cda86b --- /dev/null +++ b/icons/op-cursor-select-16.svg @@ -0,0 +1,5 @@ + + + diff --git a/icons/op-erase-16.svg b/icons/op-erase-16.svg new file mode 100644 index 000000000..df3c9a7d9 --- /dev/null +++ b/icons/op-erase-16.svg @@ -0,0 +1,5 @@ + + + diff --git a/icons/op-scissors-16.svg b/icons/op-scissors-16.svg new file mode 100644 index 000000000..6fa5a4efb --- /dev/null +++ b/icons/op-scissors-16.svg @@ -0,0 +1,5 @@ + + + diff --git a/keywords.json b/keywords.json index a35b75d69..93811603d 100644 --- a/keywords.json +++ b/keywords.json @@ -145,6 +145,10 @@ "north-star": ["star", "snowflake", "asterisk"], "note": ["card", "paper", "ticket"], "octoface": ["octocat", "brand"], + "op-cursor-rectangle-select": ["group", "select"], + "op-cursor-select": ["pointer", "select", "mouse"], + "op-erase": ["remove", "delete"], + "op-scissors": ["cut", "snip", "slice", "clip"], "organization": ["people", "group", "team"], "package": ["box", "ship"], "paintcan": ["style", "theme", "art", "color"], From 43c34005da2a01825969b66c86cd6035af481661 Mon Sep 17 00:00:00 2001 From: Eric Schubert Date: Wed, 17 Apr 2024 12:56:10 +0000 Subject: [PATCH 2/3] Optimize SVGs --- icons/op-cursor-rectangle-select-16.svg | 5 +---- icons/op-cursor-select-16.svg | 6 +----- icons/op-erase-16.svg | 6 +----- icons/op-scissors-16.svg | 6 +----- 4 files changed, 4 insertions(+), 19 deletions(-) diff --git a/icons/op-cursor-rectangle-select-16.svg b/icons/op-cursor-rectangle-select-16.svg index 024165ffd..737288cc9 100644 --- a/icons/op-cursor-rectangle-select-16.svg +++ b/icons/op-cursor-rectangle-select-16.svg @@ -1,4 +1 @@ - - - - + \ No newline at end of file diff --git a/icons/op-cursor-select-16.svg b/icons/op-cursor-select-16.svg index 977cda86b..9aae4341b 100644 --- a/icons/op-cursor-select-16.svg +++ b/icons/op-cursor-select-16.svg @@ -1,5 +1 @@ - - - + \ No newline at end of file diff --git a/icons/op-erase-16.svg b/icons/op-erase-16.svg index df3c9a7d9..b3f59eec3 100644 --- a/icons/op-erase-16.svg +++ b/icons/op-erase-16.svg @@ -1,5 +1 @@ - - - + \ No newline at end of file diff --git a/icons/op-scissors-16.svg b/icons/op-scissors-16.svg index 6fa5a4efb..35b57d1fd 100644 --- a/icons/op-scissors-16.svg +++ b/icons/op-scissors-16.svg @@ -1,5 +1 @@ - - - + \ No newline at end of file From 31250114e1c214989eb3afd35ddf75b787804344 Mon Sep 17 00:00:00 2001 From: Eric Schubert Date: Wed, 17 Apr 2024 15:05:00 +0200 Subject: [PATCH 3/3] Added more information to contribution guide --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4d633f6ef..7c37007e2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -37,6 +37,11 @@ git checkout -b ### 3. Add or update SVG files in the `/icons` directory +Be sure to add SVG files with the correct naming (suffix `-16` required, +suffixes `-12` and `-24` are optional). Check for the correct viewBox +inside the SVG, but do not bother with `fill`, `fill-rule`, or `clip-rule` +attributes, as those are removed by the CI step "Optimize SVGs". + ### 4. Add or update keywords in `keywords.json` ```diff