Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new security pages and alerts #119

Closed
3 of 5 tasks
florianschmidt1994 opened this issue Mar 22, 2020 · 7 comments
Closed
3 of 5 tasks

Implement new security pages and alerts #119

florianschmidt1994 opened this issue Mar 22, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers priority-medium

Comments

@florianschmidt1994
Copy link
Member

florianschmidt1994 commented Mar 22, 2020

We've come up with a page with dedicated security warnings for people who help others. Among other things we've also extended our list of warnings from 3 to 4. Necessary changes are

  • Show all 4 warnings on landing page
  • Implement dedicated security page according to design specs
  • Add dialog that needs to be acknowledged when a user offers its help
  • Add link to security page on success screen
  • Add link to security page in emails

If want to pick up this issue and you need any more information please let me know!
The design can be found here: https://zpl.io/a81JJqw

@marko-ignjatovic
Copy link
Contributor

Add dialog that needs to be acknowledged when a user offers its help

Hi, I am wondering how dialogs should look like. Maybe something like tailwind dialog where the user have an action button or more like a toast notification (maybe some third party package or custom)?

@florianschmidt1994
Copy link
Member Author

Hi Marko ✌️ So far we haven't spent a lot of time discussing what this should look like. I'll ping our designer and let you know as soon as possible.
I believe it would maybe even be something like a checkmark, but as I said we still have to find a good design for this

@marko-ignjatovic
Copy link
Contributor

Hi @florianschmidt1994, after I click on that design link I get this:
you-are-not-invited

@florianschmidt1994
Copy link
Member Author

florianschmidt1994 commented Mar 28, 2020

I thought those links would allow public sharing :o (But I didn't link the correct thing anyway)
I'll post some screenshots here as soon as we have them. This might take a day or two, just a heads up. Sorry for the delay

@mauriceackel
Copy link
Member

For visual reference regarding the dialog, please check out #86 .

@florianschmidt1994
Copy link
Member Author

Waiting for #153 to be merged

@mauriceackel
Copy link
Member

Closing as not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority-medium
Projects
None yet
Development

No branches or pull requests

3 participants