From f0c83a7e3309ef0cd8b16431d14abdd757d97e17 Mon Sep 17 00:00:00 2001 From: jagaSto Date: Sun, 5 Apr 2020 21:38:22 +0200 Subject: [PATCH 1/6] disable linter for exhaustive-deps rule on useEffect --- src/components/FilteredList.jsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/FilteredList.jsx b/src/components/FilteredList.jsx index b3811304..a022b0c0 100644 --- a/src/components/FilteredList.jsx +++ b/src/components/FilteredList.jsx @@ -104,7 +104,9 @@ export default function FilteredList(props) { useEffect(() => { loadDocuments(buildQuery()); - }, []); + }, + // eslint-disable-next-line react-hooks/exhaustive-deps + []); const handleChange = (address) => { setLocation(address); From cf1a57be3fb6afc5186373ceeec3f3f98e2fb690 Mon Sep 17 00:00:00 2001 From: jagaSto Date: Sun, 5 Apr 2020 21:38:30 +0200 Subject: [PATCH 2/6] add missing dependency --- src/views/CompleteOfferHelp.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/views/CompleteOfferHelp.jsx b/src/views/CompleteOfferHelp.jsx index ccbc0712..a2998646 100644 --- a/src/views/CompleteOfferHelp.jsx +++ b/src/views/CompleteOfferHelp.jsx @@ -71,7 +71,7 @@ export default function CompleteOfferHelp() { } completeSignup(); - }, []); + }, [t]); return (
From 3461d66506043069ab92993b49cfa95f3365665a Mon Sep 17 00:00:00 2001 From: jagaSto Date: Sun, 5 Apr 2020 21:38:39 +0200 Subject: [PATCH 3/6] remove conosle.log --- src/views/Press.jsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/views/Press.jsx b/src/views/Press.jsx index dd48cfbd..45d50965 100644 --- a/src/views/Press.jsx +++ b/src/views/Press.jsx @@ -23,7 +23,6 @@ export default function Press() { const [presseLink, errorGeneratingPressLink] = useFirebaseDownload('gs://quarantine-hero-assets/MarketingKit.zip', firebase); if (errorGeneratingPressLink) { - console.error('Could not generate press link', errorGeneratingPressLink); Sentry.captureException(errorGeneratingPressLink); } From 556d3dd266f80d91ae8e9ac7bc9797c85ba786a1 Mon Sep 17 00:00:00 2001 From: jagaSto Date: Sun, 5 Apr 2020 21:38:50 +0200 Subject: [PATCH 4/6] fix assets imports --- src/components/entry/Entry.jsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/entry/Entry.jsx b/src/components/entry/Entry.jsx index 7671ebe5..c8c99d8f 100644 --- a/src/components/entry/Entry.jsx +++ b/src/components/entry/Entry.jsx @@ -191,9 +191,9 @@ export default function Entry(props) { if (!reported && !prevValue) document.body.addEventListener('click', clearReportAttempt); }} > - {reported ? : null} - {!reported && !attemptingToReport ? : null} - {!reported && attemptingToReport ? : null} + {reported ? : null} + {!reported && !attemptingToReport ? : null} + {!reported && attemptingToReport ? : null} ) : null} {attemptingToReport @@ -211,7 +211,7 @@ export default function Entry(props) { onClick={reportEntry} > Post melden? - +
) : null} From 27c771c33933013b1c9371e733e8b7b76c7c00cb Mon Sep 17 00:00:00 2001 From: jagaSto Date: Sun, 5 Apr 2020 22:05:32 +0200 Subject: [PATCH 5/6] add react-hooks plugin --- .eslintrc.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 6e751c63..028756b7 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -25,7 +25,8 @@ "sourceType": "module" }, "plugins": [ - "react" + "react", + "react-hooks" ], "rules": { "max-len": "off", @@ -39,4 +40,4 @@ "jsx-a11y/click-events-have-key-events": "off", "jsx-a11y/no-static-element-interactions": "off" } -} \ No newline at end of file +} From 73fb7d9e026e6a6b0b32cc3815d6908f6b2d1687 Mon Sep 17 00:00:00 2001 From: jagaSto Date: Mon, 6 Apr 2020 20:45:36 +0200 Subject: [PATCH 6/6] disable exhaustive-deps linting rule for useEffect --- src/components/FilteredList.jsx | 4 +--- src/views/CompleteOfferHelp.jsx | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/components/FilteredList.jsx b/src/components/FilteredList.jsx index a022b0c0..468b2420 100644 --- a/src/components/FilteredList.jsx +++ b/src/components/FilteredList.jsx @@ -104,9 +104,7 @@ export default function FilteredList(props) { useEffect(() => { loadDocuments(buildQuery()); - }, - // eslint-disable-next-line react-hooks/exhaustive-deps - []); + }, []); // eslint-disable-line react-hooks/exhaustive-deps const handleChange = (address) => { setLocation(address); diff --git a/src/views/CompleteOfferHelp.jsx b/src/views/CompleteOfferHelp.jsx index a2998646..7a0e2f0f 100644 --- a/src/views/CompleteOfferHelp.jsx +++ b/src/views/CompleteOfferHelp.jsx @@ -71,7 +71,7 @@ export default function CompleteOfferHelp() { } completeSignup(); - }, [t]); + }, []); // eslint-disable-line react-hooks/exhaustive-deps return (