Allow initialization of CarsonsEquations from a dictionary.
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnjoMan
approved these changes
Oct 14, 2019
|
@AnjoMan I fixed the linter issue |
Pull Request Test Coverage Report for Build 167
💛 - Coveralls |
Pull Request Test Coverage Report for Build 206
💛 - Coveralls |
This change eliminates the need to always construct a model object to use Carson's equations. In the future, we can simplify the test code to use these dictionaries instead of classes.
etimberg
force-pushed
the
init-from-dict
branch
from
f70da95
to
af1cc9f
Compare
|
@AnjoMan do you want me to rebase this? it's ancient but I see there's some activity on the project again |
|
@etimberg i'm not sure it matters too much -- to merge, we'd have to add additional logic to cover the tape-shield stuff that just got merged in, and i'm guessing it wouldn't end up getting used anyways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates the need to always construct a model object to use Carson's equations. In the future, we can simplify the test code to use these dictionaries instead of classes.
Resolves #30