How to get clojurephant/jovial to call clojure.test/report :end-test-var?

[ngrewe]

Hi folks,

I'm porting an older project that previously relied on the clojuresque gradle plugin to clojurephant, and I'm running into a bit of a problem with the JUnit integration. My test suite defines a custom report hook for :end-test-var. When I execute the test suite in IntelliJ using Cursive, that method instead gets called as expected, but when executing ./gradlew test (using the Jovial integration), it isn't called. Can anybody point me towards why that might be happening and how to fix it? I've already tried using (defmethod dev.clojurephant.jovial.engine.clojure-test/jovial-report :end-test-var …) instead of (defmethod clojure.test/report :end-test-var …), but to no avail.

Thanks,

Niels

[ajoberstar]

I'd have to look back at Clojure's test runner to see when that function usually gets called. It could be that jovial needs to explicitly call it. However, I'm also curious if you have more context on the use case. Is this a reporting-related use case where you want something custom printed somewhere? Or is it some kind of cleanup task?

[ngrewe]

Is this a reporting-related use case where you want something custom printed somewhere? Or is it some kind of cleanup task?

It's a true reporting thing. It's writing out intermediate artefacts that are used to perform the tests so that they can be inspected manually. And since you're probably hinting at fixtures (‘cleanup’): I've tried that as well, but I can't seem to get the name of a test from a fixture…

[ajoberstar]

Looks like (at a minimum) we'll need to replicate how clojure.test calls begin/end around testing the var. I think we'd just need to add it in here.

Open to suggestions on if/how we make this extensible for end users. The (defmethod dev.clojurephant.jovial.engine.clojure-test/jovial-report :end-test-var …) that you tried is the most straightforward, but I hadn't originally intended to have a public API surface to jovial, because ideally running your test via jovial would not impact what you write in your tests. But if there's not a better way to do it transparently, that could still be an option.

[ajoberstar]

It would probably be worth adding begin/end ns reporting in the NamespaceDescriptor as well to complete the set.

[ajoberstar]

I opened this issue to track a resolution: clojurephant/jovial#23