Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct pkgconfig include directory? #43

Open
josch opened this issue Apr 2, 2018 · 1 comment
Open

correct pkgconfig include directory? #43

josch opened this issue Apr 2, 2018 · 1 comment

Comments

@josch
Copy link

josch commented Apr 2, 2018

Hi,

in the orocos-bfl.pc it says:

includedir=${prefix}/include

But with that value, the examples will not build outside of the source directory because they are not including the bfl component in the header include path. So my question is:

Is the source code shown in the example directory supposed to be real-world code examples?

If yes, they should either either:

  • add the bfl path component to the include path so that the example code better represents real-world usage examples of the orocos-bfl library or
  • the pkgconfig has to change to say: includedir=${prefix}/include/bfl
@toeklk
Copy link
Collaborator

toeklk commented Apr 13, 2018

Hmm,
That's a difficult one. Right now the examples seem (i.e. I'm not the original author) to have been created for 2 main purposes:

  • They are used in some of the tests
  • They were used to support the LaTeX documentation (currently being updated and rewritten as markdown, see issue Update documentation #7 )

I follow your concern, and I would prefer the first suggestion, yet I think that will break the compilation of the tests. I do see the advantage of reusing the code from the examples in the tests, but there's definitely also a downside to this which you revealed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants