Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared library calls exit() #9

Open
toeklk opened this issue Dec 8, 2017 · 0 comments
Open

shared library calls exit() #9

toeklk opened this issue Dec 8, 2017 · 0 comments

Comments

@toeklk
Copy link
Collaborator

toeklk commented Dec 8, 2017

exit() is called in multiple parts of the library:

% grep -RiIw exit src
src/model/measurementmodel.cpp: exit(-BFL_ERRMISUSE);
src/model/measurementmodel.cpp: exit(-BFL_ERRMISUSE);
src/model/systemmodel.cpp: exit(-BFL_ERRMISUSE);
src/model/systemmodel.cpp: exit(-BFL_ERRMISUSE);
src/pdf/pdf.h: exit(-BFL_ERRMISUSE);
src/pdf/pdf.h: exit(-BFL_ERRMISUSE);
src/pdf/pdf.h: exit(-BFL_ERRMISUSE);
src/pdf/pdf.h: exit(-BFL_ERRMISUSE);
src/pdf/analyticconditionalgaussian.cpp: exit(-BFL_ERRMISUSE);
src/pdf/filterproposaldensity.cpp: exit(-BFL_ERRMISUSE);

Calling exit() is considered to be bad practice for shared libraries and
produces warnings by the packaging tools rpmlint [1] and lintian [2].

This bug report is part of an effort to package orocos-bfl for Fedora. Fedora's
packaging guidelines require to report such issues to upstream.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=469908
[2] https://lintian.debian.org/tags/shlib-calls-exit.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant