Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix deployment annotations for maester charts #727

Open
5 tasks done
rrmistry opened this issue Jan 8, 2025 · 0 comments · May be fixed by #728
Open
5 tasks done

[Bug] Fix deployment annotations for maester charts #727

rrmistry opened this issue Jan 8, 2025 · 0 comments · May be fixed by #728
Labels
bug Something is not working.

Comments

@rrmistry
Copy link

rrmistry commented Jan 8, 2025

Preflight checklist

Ory Network Project

No response

Describe the bug

Setting the helm value deployment.annotations in the OathKeeper Maester chart does not add annotations at the deployment level, only at the pod level.

In the Ory OathKeeper Maester Helm Charts it is possible to set annotations on deployment using the below values.yaml syntax

deployment:
  annotations:
    annotation/example: foobar

This behaviour isn't consistent within the hydra-maester and oathkeeper-maester, and you can't set annotations as required.

Reproducing the bug

Installing to a maester chart to a clean cluster:

helm repo add ory https://k8s.ory.sh/helm/charts
helm repo update

helm install --set 'deployment.annotations.annotation\\.example=foobar' ory/oathkeeper-maester

Relevant log output

No response

Relevant configuration

No response

Version

Helm chart version: v0.50.6

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

Very similar to: #593

@rrmistry rrmistry added the bug Something is not working. label Jan 8, 2025
@rrmistry rrmistry linked a pull request Jan 8, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant