internal: add cacerts into customizations #1481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
requested changes
Feb 14, 2025
|
Good point; thanks, Sanne! We mainly need the type for using it on frontend now, but this might have been easily forgotten! |
|
You need https://github.com/osbuild/image-builder-crc/pull/1482/files#diff-423d98a85dc577c76a5be2a77222ea131b8fd747bdeb534b221a0e00e1b665a1R21 to get merged in order to re-run prepare source to fix this PR. Sorry, I may have introduced this. With Go 1.24 all these problems will go away with its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a field for adding ca certificates. We might also use directly the Files field, but I guess this is easier, so that the frontend does not have to deal with as many things. 🤔