Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] No hard fail when blocklist path is invalid #64

Open
Uinelj opened this issue Sep 13, 2022 · 0 comments
Open

[BUG] No hard fail when blocklist path is invalid #64

Uinelj opened this issue Sep 13, 2022 · 0 comments
Assignees
@Uinelj
Labels
bug Something isn't working
Milestone
v1.3.0

Comments

@Uinelj
Copy link
Member

Uinelj commented Sep 13, 2022 •
edited
Loading

Describe the bug
When specifying a blocklist path that is invalid, error messages do appear but the process ends "normally", with a status=0.

Either:

  1. Check path existence beforehand and stop if we have a problem with it,
  2. Fail the whole pipeline if we encounter this error somewhere.

Moreover, blocklists are instantiated once per shard and it shouldn't be that way. Maybe make ut1-blocklists Send and/or Sync, and then use a shared blocklist. -> #74
@Uinelj Uinelj added the bug Something isn't working label Sep 13, 2022
@Uinelj Uinelj self-assigned this Sep 13, 2022
@Uinelj Uinelj added this to the v1.3.0 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uinelj Uinelj

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
1 participant
@Uinelj