From 7d135a36fecea657b0ed9e6a132e638f222cfbf0 Mon Sep 17 00:00:00 2001 From: "Kent C. Dodds" Date: Fri, 3 Nov 2023 15:50:37 -0600 Subject: [PATCH] add decision document on source maps --- docs/decisions/016-source-maps.md | 2 +- docs/decisions/034-source-maps.md | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 docs/decisions/034-source-maps.md diff --git a/docs/decisions/016-source-maps.md b/docs/decisions/016-source-maps.md index 597569161..d7c2de399 100644 --- a/docs/decisions/016-source-maps.md +++ b/docs/decisions/016-source-maps.md @@ -2,7 +2,7 @@ Date: 2023-06-14 -Status: accepted +Status: superseded by [034-source-maps](034-source-maps.md) ## Context diff --git a/docs/decisions/034-source-maps.md b/docs/decisions/034-source-maps.md new file mode 100644 index 000000000..f60b73b88 --- /dev/null +++ b/docs/decisions/034-source-maps.md @@ -0,0 +1,24 @@ +# Source Maps + +Date: 2023-11-03 + +Status: accepted + +## Context + +Read [016-source-maps](016-source-maps.md) to come up to speed on the context. + +Because of our built-in sentry support, we need to generate source maps, but we +do not necessarily need to ship source maps to the client. Despite the arguments +made in the original source map decision document, the benefit of shipping +source maps over not shipping them is reduced thanks to Sentry. And the dangers +are still present. + +## Decision + +Delete source maps after they've been uploaded to Sentry. + +## Consequences + +This will mean debugging a production application in the client will be really +hard, but with Sentry properly configured it should definitely not be a problem.