Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database cleanup for power analysers #2438

Closed
flacombe opened this issue Jan 28, 2025 · 8 comments
Closed

Database cleanup for power analysers #2438

flacombe opened this issue Jan 28, 2025 · 8 comments

Comments

@flacombe
Copy link
Contributor

flacombe commented Jan 28, 2025

Hello

I've fixed this warning a few days ago: https://osmose.openstreetmap.fr/fr/issue/f5ff795c-7468-042d-d083-383c688cd3c0
On this node: https://www.openstreetmap.org/node/8409170074

But the warning still shows despite my contribution.

It seems there are remaining duplicates due to #2394: https://osmose.openstreetmap.fr/fr/issues/open?item=8290&class=1004
Renaming analysers won't cancel all warnings previously sent by old one?

Here are the sources to be deleted:

  • 448215 (Merge_power_pole_FR_gracethd_jura- france_franche_comte_jura)
  • 448210 (Merge_power_pole_FR_gracethd_dordogne- france_aquitaine_dordogne)
  • 448214 (Merge_power_pole_FR_gracethd_bretagne- france_bretagne_morbihan)
  • 448211 (Merge_power_pole_FR_gracethd_bretagne- france_bretagne_cotes_d_armor)
  • 448213 (Merge_power_pole_FR_gracethd_bretagne- france_bretagne_finistere)
  • 448212 (Merge_power_pole_FR_gracethd_bretagne- france_bretagne_ille_et_vilaine)

Some sources / items should be removed following #2444 in item 8290 :

  • 448417 (Merge_power_pole_FR_gracethd3_dordogne- france_aquitaine_dordogne ) classes 1001, 1004
  • 448418 (Merge_power_pole_FR_spec_sdey- france_bourgogne_yonne) classes 1001, 1004
  • 448419 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_cotes_d_armor ) classes 1001, 1004
  • 448420 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_ille_et_vilaine ) classes 1001, 1004
  • 448421 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_finistere ) classes 1001, 1004
  • 448422 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_morbihan ) classes 1001, 1004
  • 448423 (Merge_power_pole_FR_gracethd3_jura- france_franche_comte_jura ) classes 1001, 1004
  • 448425 (Merge_power_pole_FR_spec_sde18- france_centre_cher) classes 1001, 1004

Some replacements occurred following #2465

  • Item 8290 / classes 1014, 1024, 1034, 1044, 1054, 1064 and 1074 moved to Item 8292 / classes 1014, 1024, 1034, 1044, 1054, 1064 and 1074

Some analysis has been completely removed following #2459 and #2460

  • Item 9100 / class 91003
  • Source 446397, Item 8290 / class 2 (no occurrences in the database so far)

Best regards

@flacombe
Copy link
Contributor Author

This issue will be completed with data operations following #2444 (all classes different from 1, 3, 5 and 100x will be removed from item 8290)

@flacombe
Copy link
Contributor Author

For now, new deployment and recent run didn't removed duplicates yet

Image

@flacombe flacombe changed the title Persistent duplicates warnings on Analyser_Merge_power_pole_FR_gracethd3_jura Database cleanup for power analysers Feb 24, 2025
@frodrigo
Copy link
Member

Clean done.

Item 8290 enabled.

@flacombe
Copy link
Contributor Author

flacombe commented Mar 1, 2025

I've noticed that some classes remains in item 8290 and they should be deleted too:

  • Source 446397 class 2
  • 448417 (Merge_power_pole_FR_gracethd3_dordogne- france_aquitaine_dordogne ) class 1004
  • 448418 (Merge_power_pole_FR_spec_sdey- france_bourgogne_yonne) class 1004
  • 448419 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_cotes_d_armor ) classes 1001, 1004
  • 448420 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_ille_et_vilaine ) classes 1001, 1004
  • 448421 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_finistere ) classes 1001, 1004
  • 448422 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_morbihan ) classes 1001, 1004
  • 448423 (Merge_power_pole_FR_gracethd3_jura- france_franche_comte_jura ) class 1004
  • 448425 (Merge_power_pole_FR_spec_sde18- france_centre_cher) class 1004

It would remove 24 737 supplementary warnings

@frodrigo

@frodrigo
Copy link
Member

frodrigo commented Mar 1, 2025

Ok. Done.

@flacombe
Copy link
Contributor Author

flacombe commented Mar 1, 2025

Thank you for removal.
Just a last one remains and it will be completely ok:
448422 (Merge_power_pole_FR_gracethd3_bretagne- france_bretagne_morbihan ) classes 1001, 1004

@frodrigo
Copy link
Member

frodrigo commented Mar 2, 2025

Done

@flacombe
Copy link
Contributor Author

flacombe commented Mar 2, 2025

It's all fine, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants