Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamm proto migration #8798

Open
mattverse opened this issue Nov 1, 2024 · 0 comments
Open

Gamm proto migration #8798

mattverse opened this issue Nov 1, 2024 · 0 comments

Comments

@mattverse
Copy link
Member

Background

https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/gamm/v1beta1/balancerPool.proto#L2-L5

We had a todo on gamm proto migration, and needed extra investigation on whether we needed extra migration.

I have attempted to change the proto package with the following changes 4dbdce0 and ran an upgrade on in place testnet, getting the following error

Error: rpc error: code = Unknown desc = rpc error: code = Internal desc = no concrete type registered for type URL /osmosis.gamm.v1beta1.Pool against interface *types.CFMMPoolI: unknown request

We would need further investigation on how we should be conducting a migration on the proto package.

Suggested Design

Here, you can put concrete steps as to what to do next
e.g.

  • create test file in...

Acceptance Criteria

Goals & criteria for success
e.g.

  • all existing and new tests should pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

1 participant