Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review marked-up review from Melba Lopez #22

Open
david-a-wheeler opened this issue Jun 6, 2023 · 2 comments
Open

Review marked-up review from Melba Lopez #22

david-a-wheeler opened this issue Jun 6, 2023 · 2 comments

Comments

@david-a-wheeler
Copy link

On 2023-06-06 Melba Lopez walked through a number of comments on the S2C2 document. See the WG meeting notes for the discussion we had then. We need to walk through the rest of the comments & then decide what to do about them. I'll be attaching the PDF she shared via Slack.

@david-a-wheeler
Copy link
Author

Here is the PDF document with Melba's comments: Secure_Supply_Chain_Consumption_Framework_(S2C2F).pdf

jasminewang0 added a commit that referenced this issue Jul 7, 2023
Addressing some feedback brought up in Melba's marked up PDF - #22 

Signed-off-by: Jasmine Wang <[email protected]>
jasminewang0 added a commit that referenced this issue Jul 10, 2023
Still addressing comments from #22 

Signed-off-by: Jasmine Wang <[email protected]>
@jasminewang0
Copy link
Contributor

PR #25 addresses the following:

  • Page 7: Overlap with SLSA - addressed in Appendix (and refer to Crosswalk with SLSA #14)
  • Page 7: Branch protections/checks - this is now an idea for a supplemental guide in Create Supplemental Material for deeper dives and clarification #24
  • Page 8: Cloud agnostic - removed Azure reference
  • Page 9: EOL - added EOL reference
  • Page 10: Define "trusted sources" - removed to become "organization-defined approved sources"
  • Page 13: Maintainers to tag EOL - this guide focuses on consumption, not on the maintainers, so this suggestion is out of scope.
  • Page 13: Aspirational definition - clarified that it is aspirational as it is difficult to implement at scale.
  • Page 13: "Do not occur" vs. "may not occur" - changed to "may not occur"

The following issues are outstanding:

  • Page 4: JFrog Artifactory suggestion
  • Page 10: Internal repo/mirror of OSS contradiction
  • Page 13: SCIWG holistic 3 levels
  • Page 13: Verbiage to lead into SLSA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants