Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Do we need to have an abstract class for Strategy #183

Open
omarfoq opened this issue Aug 9, 2022 · 2 comments
Open

RFC: Do we need to have an abstract class for Strategy #183

omarfoq opened this issue Aug 9, 2022 · 2 comments

Comments

@omarfoq
Copy link
Contributor

omarfoq commented Aug 9, 2022

The strategies we implement have a lot in common. May be we need to add an abstract class Strategy.

@jeandut
Copy link
Contributor

jeandut commented Aug 15, 2022

You are right it would be better !

@Saipraneet
Copy link
Contributor

I am not so sure actually. It will add more boilerplate code which needs to be understood before a researcher can implement their new algorithm. I feel we currently have a good tradeoff between reusing code vs. keeping it self-contained.

@jeandut jeandut changed the title Do we need to have an abstract class for Strategy RFC: Do we need to have an abstract class for Strategy Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants