Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper testing for AdaGrad, Yogi and FedAvg based on FedAdam testing #67

Open
jeandut opened this issue May 9, 2022 · 0 comments
Open

Add proper testing for AdaGrad, Yogi and FedAvg based on FedAdam testing #67

jeandut opened this issue May 9, 2022 · 0 comments
Labels
good first issue Good for newcomers testing

Comments

@jeandut
Copy link
Contributor

jeandut commented May 9, 2022

It would be nice if one client only testing could be used with allclose statements to check perfect equality between federated versions and their torch.optim counterparts.
This is done for now only for FedAdam in tests/strategies/test_fed_adam.py
@jeandut jeandut added good first issue Good for newcomers testing labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeandut