trs uses * and TRSinfo does not have correct # of multiplications

[rs1909]

Try the following code

using LinearAlgebra
using TRS
import Base.*
import Base.eltype
import Base.size
import LinearAlgebra.mul!
import LinearAlgebra.issymmetric

struct MM
           A
end

size(p::MM,i) = size(p.A,i)
eltype(p::MM) = eltype(p.A)
issymmetric(p::MM) = LinearAlgebra.issymmetric(p.A)
*(p::MM,b) = begin print("+"); p.A * b end
mul!(x::AbstractVector, p::MM, y::AbstractVector) = begin print("."); mul!(x, p.A, y) end

bb = randn(1000,1000)
P = MM(Symmetric(bb))

trs(P, randn(1000), 10.01, tol = 1e-5)

The result is
............................................................................................................................................................................................................................................+++++++++++++++++++++++++++++++++++++++++++([0.9118078944996598; 0.17858464580297087; … ; 0.004596302762534588; -0.28270136894221026;;], TRS.TRSinfo(false, 10, 236, [62.17093160622234]))

Firstly the docs says that only mul! needs to defined. Secondly the actual multiplications are 279, instead of the reported 236.

It might not be an issue, but I feel this is somewhat suspicious.