Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

3.2.0 introduced a breaking change without a 4.0.0 version bump #304

Closed
displague opened this issue Dec 10, 2020 · 2 comments · Fixed by #305
Closed

3.2.0 introduced a breaking change without a 4.0.0 version bump #304

displague opened this issue Dec 10, 2020 · 2 comments · Fixed by #305

Comments

@displague
Copy link
Member

displague commented Dec 10, 2020

The solution to #289 introduced a breaking change without a major version bump.

Can we remove the 3.2.0 version stamp? If so, how does this affect users that are already using 3.2.0?

How does this affect users with the often suggested setting: hardware_reservation_id = "next-available"

What steps should users take when migrating to 4.0.0?

The CHANGELOG should be updated to reflect any changes and

@displague
Copy link
Member Author

For example, if a user that had hardware_reservation_id = "next-available" will have a stateful value, post-provision of hardware_reservation_id = {some-uuid}.

Upon updating to 3.2.0, the next plan will want to destroy those resources to reset the hardware_reservation_id to next-available.

@displague
Copy link
Member Author

To address this problem as a 3.2.1 change, the diff could be ignored when going from {uuid} to next-available. Should a 4.0.0 then revert that change to the current behavior? What migration notes should we provide?

Notes on migrating from this state should be included in equinix/terraform-provider-metal#1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant