Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a shorter version of the --identifier option #2259

Closed
1 of 2 tasks
psss opened this issue Nov 28, 2023 · 8 comments · Fixed by #2309
Closed
1 of 2 tasks

Support a shorter version of the --identifier option #2259

psss opened this issue Nov 28, 2023 · 8 comments · Fixed by #2309
Labels
area/user-experience Usability issue gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.

Comments

@psss
Copy link
Contributor

psss commented Nov 28, 2023

Description

Scheduling a manual_trigger job is quite frequent action. Would you be willing to provide a shorter version of the identifier option to save a bunch of keystrokes?

Instead of:

/packit test --identifier full

It could look like this:

/packit test --id full

Or even this?

/packit test -i full

What do you say?

Benefit

Hundreds of keystrokes saved...
More pull requests merged...
Lower energy consumption...
Higher productivity... ;-)

Importance

No response

What is the impacted category (job)?

Testing Farm tests

Workaround

  • There is an existing workaround that can be used until this feature is implemented.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@psss psss added the kind/feature New feature or a request for enhancement. label Nov 28, 2023
@psss psss mentioned this issue Nov 28, 2023
Merged
2 tasks
@kkaarreell
Copy link

or /packit test full or /packit test/full. IMHO id seems to be so important attribute, that we could accept extra approach of specifying it.

@psss
Copy link
Contributor Author

psss commented Nov 28, 2023

or /packit test full

That would be even better!

IMHO id seems to be so important attribute, that we could accept extra approach of specifying it.

Agreed.

@lbarcziova
Copy link
Member

hi @psss @kkaarreell ! I understand, implementing the -i or --id aliases would be probably really easy and makes sense. I am afraid that accepting it as a standalone argument would collide with the current argument for build from another PR, see the docs. On the other hand, in #2200 we discussed the parsing of arguments and additionally starting utilising argparse, which would probably make this easier to happen.

@psss
Copy link
Contributor Author

psss commented Nov 28, 2023

I am afraid that accepting it as a standalone argument would collide with the current argument for build from another PR, see the docs.

I see, understood. On the other hand, in the documentation I see:

This is a new feature, so the behaviour may be adjusted in the future.

So... perhaps, we could give precedence to the identifier use case as that will probably be much more frequent use case? At least that's what I expect from my point of view, but yeah, others might feel it differently...

@psss psss changed the title Add support for a shorter version of the --identifier option Support a shorter version of the --identifier option Nov 28, 2023
@lbarcziova
Copy link
Member

will probably be much more frequent use case

yes, I agree with that! Putting here discuss label to discuss with the team.

@lbarcziova lbarcziova added the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Nov 28, 2023
@majamassarini majamassarini added area/user-experience Usability issue complexity/single-task Regular task, should be done within days. impact/high This issue impacts multiple/lot of users. gain/low This doesn't bring that much value to users. labels Nov 30, 2023
@majamassarini majamassarini moved this from new to backlog in Packit Kanban Board Nov 30, 2023
@majamassarini
Copy link
Member

We go for now with the implementation of --id and -i.
With the redesign we also take in consideration of making it an argument.

@majamassarini majamassarini added complexity/easy-fix and removed discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) complexity/single-task Regular task, should be done within days. labels Nov 30, 2023
@psss
Copy link
Contributor Author

psss commented Nov 30, 2023

We go for now with the implementation of --id and -i.

Thanks.

With the redesign we also take in consideration of making it an argument.

That would be great!

@psss psss mentioned this issue Jan 19, 2024
Merged
4 tasks
@psss
Copy link
Contributor Author

psss commented Jan 19, 2024

Should be covered by #2309.

psss added a commit to psss/packit-service that referenced this issue Jan 19, 2024
@psss
Support --id and -i as a test job identifier
edf01b4 
Add support for shorter version of the `--identifier` option to
save many keystrokes when triggering custom jobs.

Fix packit#2259.
softwarefactory-project-zuul bot added a commit that referenced this issue Jan 19, 2024
@softwarefactory-project-zuul
Support --id and -i as a test job identifier (#2309)
41f7734 
Support `--id` and `-i` as a test job identifier

Add support for shorter version of the --identifier option to save many keystrokes when triggering custom jobs.
Fix #2259.
TODO:

 Write new tests or update the old ones to cover new functionality.
 Update doc-strings where appropriate.
 Update or write new documentation in packit/packit.dev.
 ‹fill in›



Fixes
Related to
Merge before/after

RELEASE NOTES BEGIN

RELEASE NOTES END

Reviewed-by: Laura Barcziová
@github-project-automation github-project-automation bot moved this from backlog to done in Packit Kanban Board Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/user-experience Usability issue gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support --id and -i as a test job identifier psss/packit-service
4 participants
@majamassarini @psss @kkaarreell @lbarcziova