Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does not create new chroots when packit config changes after a PR rebase #2262

Closed
1 of 2 tasks
evgeni opened this issue Nov 30, 2023 · 4 comments · Fixed by packit/packit#2194
Closed
1 of 2 tasks

does not create new chroots when packit config changes after a PR rebase #2262

evgeni opened this issue Nov 30, 2023 · 4 comments · Fixed by packit/packit#2194
Assignees
@lbarcziova
Labels
area/config Related to the Packit's configuration. area/copr Related to the integration with copr.fedorainfracloud.org/ complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.

Comments

@evgeni
Copy link
Contributor

evgeni commented Nov 30, 2023

What happened? What is the problem?

In Foreman, we recently switched from building against centos-stream-8 to rhel-8, however, it seems that PRs that have been opened before this change do not get their respective copr projects updated and thus fail to build with "Chroot name rhel-8-x86_64 does not exist in Copr packit/theforeman-foreman-9837."

Example: https://github.com/theforeman/foreman/pull/9837/checks?check_run_id=19147230758

What did you expect to happen?

The copr project is updated to reflect the changes in packit.yml and thus succeeds to build

Example URL(s)

https://github.com/theforeman/foreman/pull/9837/checks?check_run_id=19147230758

Steps to reproduce

1. open a PR
2. change packit config in base branch
3. rebase PR

What is the impacted category (job)?

Copr builds

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@evgeni evgeni added the kind/bug Something isn't working. label Nov 30, 2023
@lachmanfrantisek lachmanfrantisek self-assigned this Dec 4, 2023
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 4, 2023 •
edited by lbarcziova
Loading

Sentry issue: PCKT-002-PACKIT-SERVICE-6MW

@lbarcziova : this is the actual reason of the failure, the Packit config contains chroot-specific configuration and we do not handle that correctly

@evgeni evgeni mentioned this issue Dec 5, 2023
Merged
@lachmanfrantisek lachmanfrantisek added area/copr Related to the integration with copr.fedorainfracloud.org/ impact/high This issue impacts multiple/lot of users. gain/low This doesn't bring that much value to users. area/config Related to the Packit's configuration. complexity/single-task Regular task, should be done within days. labels Jan 8, 2024
@lachmanfrantisek lachmanfrantisek moved this from new to ready-to-refine in Packit Kanban Board Jan 8, 2024
@lachmanfrantisek
Copy link
Member

Closing in favour of #1854 which should fix it.

@lachmanfrantisek lachmanfrantisek closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
@github-project-automation github-project-automation bot moved this from ready-to-refine to done in Packit Kanban Board Jan 8, 2024
@lachmanfrantisek lachmanfrantisek mentioned this issue Jan 8, 2024
Closed
@lbarcziova
Copy link
Member

I am not sure #1854 is the same 🤔

This one should be about wrong handling of chroot-specific configuration when the chroots are updated and #1854 is about multiple copr_build jobs building in the same Copr project where each job has different targets.

@nforro
Copy link
Member

nforro commented Jan 8, 2024

I agree with @lbarcziova, this is a different issue.

@nforro nforro reopened this Jan 8, 2024
@nforro nforro moved this from done to new in Packit Kanban Board Jan 8, 2024
@lachmanfrantisek lachmanfrantisek moved this from new to ready-to-refine in Packit Kanban Board Jan 9, 2024
@lachmanfrantisek lachmanfrantisek removed their assignment Jan 11, 2024
@lachmanfrantisek lachmanfrantisek moved this from ready-to-refine to refined in Packit Kanban Board Jan 11, 2024
@lbarcziova lbarcziova self-assigned this Jan 12, 2024
@lbarcziova lbarcziova moved this from refined to in-progress in Packit Kanban Board Jan 12, 2024
lbarcziova added a commit to lbarcziova/packit that referenced this issue Jan 15, 2024
@lbarcziova
Update chroot specific Copr config after chroot update itself
23f393f 
Change the order of updating a Copr project:
1. update the chroots themselves
2. after that, we can update the chroot specific configuration

Also, wrap the updating of chroot specific configuration to the try-except
to cover the case of insufficient permissions.
Fixes packit/packit-service#2262
@lbarcziova lbarcziova mentioned this issue Jan 15, 2024
Merged
@lbarcziova lbarcziova moved this from in-progress to in-review in Packit Kanban Board Jan 15, 2024
lbarcziova added a commit to lbarcziova/packit that referenced this issue Jan 18, 2024
@lbarcziova
Update chroot specific Copr config after chroot update itself
a277505 
Change the order of updating a Copr project:
1. update the chroots themselves
2. after that, we can update the chroot specific configuration

Also, wrap the updating of chroot specific configuration to the try-except
to cover the case of insufficient permissions.
Fixes packit/packit-service#2262
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this issue Jan 18, 2024
@softwarefactory-project-zuul
Chroot-specific config update fix (#2194)
9c8f50e 
Chroot-specific config update fix

Fixes packit/packit-service#2262
RELEASE NOTES BEGIN
We have fixed a bug in handling chroot-specific configuration once the chroots themselves are updated.
RELEASE NOTES END

Reviewed-by: Maja Massarini
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/config Related to the Packit's configuration. area/copr Related to the integration with copr.fedorainfracloud.org/ complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chroot-specific config update fix lbarcziova/packit
4 participants
@evgeni @nforro @lachmanfrantisek @lbarcziova