Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom resolvedTheme #142

Open
phuctm97 opened this issue Oct 13, 2022 · 0 comments
Open

Support custom resolvedTheme #142

phuctm97 opened this issue Oct 13, 2022 · 0 comments

Comments

@phuctm97
Copy link
Contributor

In multiple themes scenario with enableSystem=true, would be convenient to provide a custom them resolution logic. For example, one may have light, light-red, light-blue, dark, dark-red, dark-blue, a custom resolution will maintain same color, only change light ↔️ dark. This can currently be done by disabling enableSystem and implementing custom effect.

Suggested solution: allow optional prop resolveTheme, which is a function with argument is the current theme and resolved system theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant