Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the SDK #20

Open
ghost opened this issue Aug 25, 2024 · 2 comments
Open

Rewrite the SDK #20

ghost opened this issue Aug 25, 2024 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Aug 25, 2024

Hello, Pactus developers.
I wanted to use the SDK but the structure of SDK is not developer-friendly it just provides auto-generated GRPCs API and some functionality they not useful.
the point of SDKs is to create things easy to use, I want to rewrite the whole SDK to improve the structure and functionality.
I hope it is acceptable

@kehiy
Copy link
Contributor

kehiy commented Aug 25, 2024

@0keeper1 Hi, that's nice too see you are interested in contributing.

Make sure you don't break current behavior or tests over all. and consider that the gRPC file at the moment have an open issue may it can affect your changes in rpc package. so, make sure you take a look at it before adding codes:

@kehiy kehiy assigned ghost Aug 25, 2024
@kehiy kehiy added enhancement New feature or request improvement refactor labels Aug 25, 2024
@ghost
Copy link
Author

ghost commented Aug 25, 2024

@0keeper1 Hi, that's nice too see you are interested in contributing.

Make sure you don't break current behavior or tests over all. and consider that the gRPC file at the moment have an open issue may it can affect your changes in rpc package. so, make sure you take a look at it before adding codes:

* [gRPC packages and paths #19](https://github.com/pactus-project/python-sdk/issues/19)

about this issue, I will re-generate the GRPCs. and I will fix the issues.
And I will release the SDK with version 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant