Get rid of the pangeo-forge image #477
Conversation
|
|
|
/condalock |
There was a problem hiding this comment.
Thanks @yuvipanda! This will simplify maintenance going forward, as we won't need to do stuff like #470 anymore. Just some suggested changes on the main README.md and should be ok.
| | [forge](ml-notebook/packages.txt) | pangeo-notebook + [Apache Beam](https://beam.apache.org/) support|  |  | ||
|
|
||
| *Click on the image name in the table above for a current list of installed packages and versions* | ||
|
|
There was a problem hiding this comment.
In this file, could you also:
- Remove the
click forge "https://hub.docker.com/r/pangeo/forge" "Open this in a new tab" _blankline at L36? - Mention in the 'Other notes' section that the
forgeimage is no longer built/maintained, but old versions can be found at https://quay.io/repository/pangeo/forge?tab=tags
There was a problem hiding this comment.
Thanks @yuvipanda ! unfortunately a few conflicts now that other things have been merged. Are you able to revisit this?
|
I'm waiting to hear from @cisaacstern before moving forward. We all agree this is the path forward - the question now is, do we wait for pangeo-forge/pangeo-forge-runner#90 to be merged before merging this, or can we do that before? |
The |
How long is the foreseeable future? As long as the old images will be archived for long enough to ensure we'll have made the transition by the time the archive expires, I'm 👍 |
No longer needed as of pangeo-forge/pangeo-forge-runner#90! This simplifies pangeo-forge maintenance as well, as we no longer have to match versions of python and apache_beam with whatever is going on here.
yuvipanda
force-pushed
the
no-mo-forge
branch
from
5c51d77
to
57a8d77
Compare
|
Thanks for chiming in, @cisaacstern! I've resolved the merge conflicts, and updated the README, @weiji14! |
Well, there isn't an expiry date set for the quay.io hosted images (see Expires = Never in screenshot below), so it should be until they change their terms and conditions 🙂
|
There was a problem hiding this comment.
Thanks @yuvipanda! Will simplify maintenance going forward.
|
Awesome LGTM! Thanks all! |
No longer needed as of
pangeo-forge/pangeo-forge-runner#90!
This simplifies pangeo-forge maintenance as well, as we no longer have to match versions of python and apache_beam with whatever is going on here.