Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump conda-lock to 2.5, and increase locking timeout to 45min #546

Merged
merged 3 commits into from
May 17, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented May 17, 2024

Some updates cherry-picked from #514 to enable the CUDA upgrade from 11.8 to 12.0.

The 45min timeout might be a bit too generous, I can reduce it down to 30min or something after seeing what is actually required in #514 to lock the pytorch-notebook environment.

@weiji14 weiji14 self-assigned this May 17, 2024
Copy link
Contributor

Binder 👈 Try on Mybinder.org!

@scottyhq
Copy link
Member

The 45min timeout might be a bit too generous, I can reduce it down to 30min or something after seeing what is actually

Yeah, the default is 6 hours according to
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

Anything over a few minutes seems odd, I have no idea how these solvers work behind the scenes, but I wonder if it's worth opening an issue on conda-lock if it continues to spin. I had a quick look and only saw this possibly related one conda/conda-lock#438

@scottyhq scottyhq merged commit 0547dc5 into master May 17, 2024
6 checks passed
@scottyhq scottyhq deleted the condalock-2.5 branch May 17, 2024 22:43
@weiji14
Copy link
Member Author

weiji14 commented May 21, 2024

Seems like 45min didn't work either, so I'm increasing the timeout to 3 hours in #547. If that still doesn't work, I'll open an issue on https://github.com/conda-incubator/conda-lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants