Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unnecessary arguments optional #67

Open
IlyaSemenov opened this issue Oct 20, 2020 · 2 comments
Open

Make unnecessary arguments optional #67

IlyaSemenov opened this issue Oct 20, 2020 · 2 comments

Comments

@IlyaSemenov
Copy link

Please make the following arguments optional:

  • onClosed
  • onEndReached

Right now user must pass empty handlers such as onClosed={() => {}}.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.76. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@IlyaSemenov
Copy link
Author

Also, I don't see how items[x].Value is ever used, so it doesn't have to be required, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant