Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Multiple calls import the same items again #36

Closed
alexfikl opened this issue Sep 22, 2023 · 2 comments
Closed

sql: Multiple calls import the same items again #36

alexfikl opened this issue Sep 22, 2023 · 2 comments

Comments

@alexfikl
Copy link
Contributor

From #33

Importing already "imported" items.

I find it unintuitive that if you are running the import again, and you already have those items as folders/files on your system and they are probably being written over there is no "WARNIG" or "CHOICE" about this. I'm not sure what to recommend. Maybe something like

[INFO] Trying to export item XYZ (a nice  first neutral message)
[WARNING] Item XYZ already in the papis folder foo/bar. 
[INFO] Skipped trying to import item XYZ. Use --force to rewrite those folders/files
[INFO] Trying to export item XYZ (a nice  first neutral message)

and when using that "force",

[INFO] Trying to export item XYZ (a nice  first neutral message)
[WARNING] Item XYZ already in the papis folder foo/bar. 
[INFO] Force option used. folder/fileXYZ overwritten
[INFO] Sucessfuly imported item XYZ.
[INFO] Trying to export item XYZ (a nice  first neutral message)
@kiike
Copy link
Contributor

kiike commented Mar 6, 2024

This problem is now fixed with the recent commits in #43: the papis API is now taking care of adding, and asking for confirmation on adding duplicated files. The flags --no-confirm and --confirm should provide/avoid interaction on such cases.

@alexfikl
Copy link
Contributor Author

alexfikl commented Mar 6, 2024

Agreed! Thanks for working on that 😁

@alexfikl alexfikl closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants