Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out block to payload compat fns #14131

Closed
mattsse opened this issue Jan 31, 2025 · 6 comments
Closed

Phase out block to payload compat fns #14131

mattsse opened this issue Jan 31, 2025 · 6 comments
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 31, 2025

Describe the feature

these can now be replaced

pub fn block_to_payload_v3<T: SignedTransaction>(

with ExecutionPayloadV3::from_block_unchecked(block.hash(), &block.into_block())

where used, e.g.:

let payload = block_to_payload_v3(block.clone_sealed_block());

TODO

  • remove remaining payload fn in

//! Standalone Conversion Functions for Handling Different Versions of Execution Payloads in

ideally submitted one by one to make reviewing easy

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 31, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Jan 31, 2025
@18aaddy
Copy link
Contributor

18aaddy commented Jan 31, 2025

@mattsse I would like to work on this.

@temaniarpit27
Copy link
Contributor

I’d like to help with this.

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 1, 2025

cool, one was removed in #14140
we still have a few more

@stevencartavia
Copy link
Contributor

🙋🏽‍♂️

@temaniarpit27
Copy link
Contributor

@mattsse #14142

@temaniarpit27
Copy link
Contributor

@mattsse #14143

@mattsse mattsse closed this as completed Feb 1, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

No branches or pull requests

4 participants