-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase out block to payload compat fns #14131
Labels
A-rpc
Related to the RPC implementation
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Comments
@mattsse I would like to work on this. |
I’d like to help with this. |
cool, one was removed in #14140 |
🙋🏽♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rpc
Related to the RPC implementation
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Describe the feature
these can now be replaced
reth/crates/rpc/rpc-types-compat/src/engine/payload.rs
Line 47 in d3acdda
with
ExecutionPayloadV3::from_block_unchecked(block.hash(), &block.into_block())
where used, e.g.:
reth/crates/engine/tree/src/tree/mod.rs
Line 3186 in d3acdda
TODO
reth/crates/rpc/rpc-types-compat/src/engine/payload.rs
Line 1 in d3acdda
ideally submitted one by one to make reviewing easy
Additional context
No response
The text was updated successfully, but these errors were encountered: