Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for type decoding #71

Open
dvdplm opened this issue Nov 8, 2021 · 2 comments
Open

Benchmarks for type decoding #71

dvdplm opened this issue Nov 8, 2021 · 2 comments

Comments

@dvdplm
Copy link
Contributor

dvdplm commented Nov 8, 2021

It would be good to have a few benchmarks for decoding types from JSON, perhaps taking inspiration from resolver::tests::should_get_types_from_json and other slow/heavy duty tests. Ideally we should run the benches in CI and store the results to check for regressions (fine to do in separate PRs though).

@jsdw
Copy link
Collaborator

jsdw commented Nov 23, 2021

Just to clarify, do you mean benchmarks decoding from SCALEd bytes to Value's? (It would be nice to have those for sure!)

Or are you thinking more about the legacy versions of desub which decode type information from the JSON files?

@dvdplm
Copy link
Contributor Author

dvdplm commented Nov 25, 2021

I meant both really!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants