Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6 - update code-editor header in examples #3887

Closed
kmcfaul opened this issue Feb 14, 2024 · 0 comments · Fixed by #3951
Closed

v6 - update code-editor header in examples #3887

kmcfaul opened this issue Feb 14, 2024 · 0 comments · Fixed by #3951

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 14, 2024

The generated code editor header that appears under each example needs to be updated to include a new isHeaderPlain modifier once patternfly/patternfly-react#10081 merges. The buttons inside the header also should be variant="plain" now instead of variant="control".
@kmcfaul kmcfaul added the Penta label Feb 14, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Feb 14, 2024
@kmcfaul kmcfaul linked a pull request Apr 2, 2024 that will close this issue
feat(misc): update alpha versions #3951
Merged
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(misc): update alpha versions patternfly/patternfly-org
2 participants
@jessiehuff @kmcfaul