Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile warnings originating in lib/petal_components_web/a11y_live.ex #371

Closed
grzuy opened this issue Nov 11, 2024 · 4 comments
Closed

Compile warnings originating in lib/petal_components_web/a11y_live.ex #371

grzuy opened this issue Nov 11, 2024 · 4 comments

Comments

@grzuy
Copy link
Contributor

grzuy commented Nov 11, 2024

Hi there 👋

Seeing quite a few compile warnings coming from lib/petal_components_web/a11y_live.ex for a Phoenix application depending on petal_components 2.5.2.

image

Anyone else?

@grzuy
Copy link
Contributor Author

grzuy commented Nov 11, 2024

Is lib/petal_components_web/a11y_live.ex file really intended to be included in petal_components published releases? Or only development and testing?

If only dev and test, should it be moved to test/support/?
So it's not included in releases and in end user applications?

Thanks in advance.

@grzuy grzuy changed the title Warnings in lib/petal_components_web/a11y_live.ex Compile warnings originating in lib/petal_components_web/a11y_live.ex Nov 11, 2024
@grzuy
Copy link
Contributor Author

grzuy commented Nov 11, 2024

To provide some more context.

Seen that it was added in this Pull request: https://github.com/petalframework/petal_components/pull/326/files#diff-443233b9c679556d43885b3f3babee59b9c5c33da48887d591513e423d558f3bR17. Apparently called only from the test/test_helper.exs. Reason why I was wondering it was a test only utility or not.

@mitkins
Copy link
Collaborator

mitkins commented Nov 11, 2024

Hi @grzuy with regards to the warning messages, this is being addressed in #368.

With regards to a11y_live.ex. Yes, it is for development and testing. It looks like the main reason why it's in the lib/petal_components_web is so you can do the following:

$ iex -S mix
iex> Run.playground()

Is it mainly the warning messages that you're concerned with?

@grzuy
Copy link
Contributor Author

grzuy commented Nov 12, 2024

Yes, that fixes it.
Thank you.

@grzuy grzuy closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants