Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better hook for completion engine in RubSmalltalkTextEditor #17895

Open
Ducasse opened this issue Feb 27, 2025 · 2 comments
Open

Better hook for completion engine in RubSmalltalkTextEditor #17895

Ducasse opened this issue Feb 27, 2025 · 2 comments

Comments

@Ducasse
Copy link
Member

Ducasse commented Feb 27, 2025

Right now we can specify at the class level the class of an engine.

RubSmalltalkEditor completionEngineClass: CoCompletionEngine.

This forces us to define a completion engine class for each configuration.

We would like to specify on the class RubSmalltalkEditor instance of an engine
this way we could configure and engine and that all the Rub instances uses it.

@Ducasse
Copy link
Member Author

Ducasse commented Feb 27, 2025

The instance creation logic is right now

completionEngine

	^ completionEngine ifNil: [
		CompletionEngineClass ifNotNil: [
			self completionEngine: CompletionEngineClass new.
			completionEngine ] ]

@Ducasse
Copy link
Member Author

Ducasse commented Feb 27, 2025

#17896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant