Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TimeControlNode for Play/Pause/Step buttons #166

Open
jessegreenberg opened this issue Dec 11, 2019 · 1 comment
Open

Use TimeControlNode for Play/Pause/Step buttons #166

jessegreenberg opened this issue Dec 11, 2019 · 1 comment
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

From phetsims/scenery-phet#561. A scenery-phet/TimeControlNode was created that combines the PlayPauseButton and StepForwardButton and includes PhET-iO and PDOM instrumentation. It should be used in this sim. Assigning to responsible dev.
@jessegreenberg jessegreenberg self-assigned this Dec 11, 2019
jessegreenberg added a commit that referenced this issue Sep 23, 2021
@jessegreenberg
use enabledProperty instead of isPlayingProperty for StepButton, see p…
0eb38c7 
…hetsims/scenery-phet#563 and #166
@jessegreenberg
Copy link
Contributor Author

The API for StepButton changed and isPlayingProperty was replaced with enabledProperty. When TimeControlNode is used in this sim the setting of enabledProperty can be removed because it is the default behavior for TimeControlNode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg