Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"update this when requested" for colors #177

Open
pixelzoom opened this issue Sep 14, 2023 · 0 comments
Open

"update this when requested" for colors #177

pixelzoom opened this issue Sep 14, 2023 · 0 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

In 4755e49, @jonathanolson added these TODOs to RutherfordAtomScreenView for phetsims/scenery-phet#278. We have no idea what "when requested" is referring to, or why they would need to be updated.

@jonathanolson Do you recall why these TODOs were added?

        baseColor: RSColors.panelColorProperty.value, // TODO: update this when requested
...
          deselectedStroke: RSColors.panelBorderColorProperty.value, // TODO: update this when requested https://github.com/phetsims/tasks/issues/1129
          selectedStroke: RSColors.radioButtonBorderColorProperty, // TODO: update this when requested https://github.com/phetsims/tasks/issues/1129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants