-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Icon changes do not take effect in the mobile toolbar. #125
Comments
I second this, and it's not just for macros. It applies for any command that doesn't have an icon -- no matter what icon I select for them, it still renders the question mark in a circle default icon. I'm working on this now. |
Bizarre -- the icon mappings I have saved worked for a day or two a week ago but has since reverted to the default, question-mark-in-a-circle icon for all of them. |
This is happening for me as well, though the changes appear for a while. They disappear when I restart Obsidian. |
@BitComing @jackbrannen I've made a mobile toolbar for Obsidian that fully supplants obsidian-commander's version, wanna give it a go? obsidian://show-plugin?id=gay-toolbar |
@ChasKane Yes definitely gonna try this out and will report back. Thanks! |
I’ve fixed the issue and opened a PR. If you don't feel like waiting for it to be merged, you can use my release here in the meantime. |
@Lyqed Can you explain how to use your release? ChatGPT was not helpful. 😩 |
Simply download all three files and place them in the .obidian/plugin/[commander-plugin-folder-name] and then unload and load the plugin from obsidian settings. |
@Lyqed Thank you! That worked great. |
Describe the bug
Relevant errors (if available)
No response
Steps to reproduce
1, add macros, choose any command and select the icon.
![Screenshot_2024-03-11-01-50-33-193_top bienvenido saas i18n-edit](https://private-user-images.githubusercontent.com/68539160/311530130-1a30867e-af14-4a71-83f4-bb586b0ab9cb.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMjI1MjUsIm5iZiI6MTczOTEyMjIyNSwicGF0aCI6Ii82ODUzOTE2MC8zMTE1MzAxMzAtMWEzMDg2N2UtYWYxNC00YTcxLTgzZjQtYmI1ODZiMGFiOWNiLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDE3MzAyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkODBhZjE5NTQ4NjdlOTMzMWU5NWUwYzk5ZTU2MjRhYzBhOGY0N2ExMjRkNzI4OGQxOGVjZTU3ZGY0YjZmOGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wF0sufeS48H31SfUrQPQge9B1gz3eOB-41j-Ihw7zeY)
2.Add commands on mobile toolbar.
![Screenshot_2024-03-11-01-51-28-364_top bienvenido saas i18n-edit](https://private-user-images.githubusercontent.com/68539160/311530169-dff8ad6e-defa-46bb-9e50-268d5b4d6ef2.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMjI1MjUsIm5iZiI6MTczOTEyMjIyNSwicGF0aCI6Ii82ODUzOTE2MC8zMTE1MzAxNjktZGZmOGFkNmUtZGVmYS00NmJiLTllNTAtMjY4ZDViNGQ2ZWYyLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDE3MzAyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBiY2M5YmVkMTdmY2Q0MDgyYWYyNzFmZmFjYmY2ZDdiYWJmMTI3NjA5ODgyNGQ5YjQzODA2YWU4NWQxNjRiNjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KSfSPjM7cMa2hzTqnOQNtVj88tnxp2C7a3BBYKXLlQ8)
![Screenshot_2024-03-11-01-53-33-146_top bienvenido saas i18n-edit](https://private-user-images.githubusercontent.com/68539160/311530424-28146e1c-b2be-40d0-b337-e4b3c9fd8653.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMjI1MjUsIm5iZiI6MTczOTEyMjIyNSwicGF0aCI6Ii82ODUzOTE2MC8zMTE1MzA0MjQtMjgxNDZlMWMtYjJiZS00MGQwLWIzMzctZTRiM2M5ZmQ4NjUzLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDE3MzAyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM5ODYwYjRkN2Y2NDhhOTM1YTBhNTc0NWY2YTUxNzkyZjYxNWUwMGQxMTRmZTIyMTk3YThkMTQ1OTU1MDE1MGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.npWei8ihfcvRwHsB8oLc9O-5zUg4L69pv-7bAf4LhRQ)
3, on the mobile toolbar did not show the new icon as expected.
Expected Behavior
No response
Additional context
No response
Operating system
Android
The text was updated successfully, but these errors were encountered: