Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Icon changes do not take effect in the mobile toolbar. #125

Open
BitComing opened this issue Mar 10, 2024 · 9 comments
Open

[Bug]: Icon changes do not take effect in the mobile toolbar. #125

BitComing opened this issue Mar 10, 2024 · 9 comments

Comments

@BitComing
Copy link

Describe the bug

Screenshot_2024-03-11-01-42-02-339_com miui gallery

Relevant errors (if available)

No response

Steps to reproduce

1, add macros, choose any command and select the icon.
Screenshot_2024-03-11-01-50-33-193_top bienvenido saas i18n-edit

2.Add commands on mobile toolbar.
Screenshot_2024-03-11-01-51-28-364_top bienvenido saas i18n-edit
Screenshot_2024-03-11-01-53-33-146_top bienvenido saas i18n-edit

3, on the mobile toolbar did not show the new icon as expected.

Expected Behavior

No response

Additional context

No response

Operating system

Android

@ChasKane
Copy link

I second this, and it's not just for macros. It applies for any command that doesn't have an icon -- no matter what icon I select for them, it still renders the question mark in a circle default icon. I'm working on this now.

@ChasKane
Copy link

Bizarre -- the icon mappings I have saved worked for a day or two a week ago but has since reverted to the default, question-mark-in-a-circle icon for all of them.

@jackbrannen
Copy link

This is happening for me as well, though the changes appear for a while. They disappear when I restart Obsidian.

@ChasKane
Copy link

ChasKane commented Dec 9, 2024

@BitComing @jackbrannen I've made a mobile toolbar for Obsidian that fully supplants obsidian-commander's version, wanna give it a go?

obsidian://show-plugin?id=gay-toolbar
https://github.com/ChasKane/gay-toolbar

@jacksojourn
Copy link

@ChasKane Yes definitely gonna try this out and will report back. Thanks!

@Lyqed
Copy link

Lyqed commented Dec 20, 2024

I’ve fixed the issue and opened a PR.

If you don't feel like waiting for it to be merged, you can use my release here in the meantime.

@jackbrannen
Copy link

@Lyqed Can you explain how to use your release? ChatGPT was not helpful. 😩

@Lyqed
Copy link

Lyqed commented Jan 11, 2025

@Lyqed Can you explain how to use your release? ChatGPT was not helpful. 😩

Simply download all three files and place them in the .obidian/plugin/[commander-plugin-folder-name] and then unload and load the plugin from obsidian settings.

@jackbrannen
Copy link

@Lyqed Thank you! That worked great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants