Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make class="btn" clickable / Or support clickable css rule extention #3550

Closed
eromoe opened this issue Apr 28, 2020 · 2 comments
Closed

Make class="btn" clickable / Or support clickable css rule extention #3550

eromoe opened this issue Apr 28, 2020 · 2 comments

Comments

@eromoe
Copy link

eromoe commented Apr 28, 2020 •
edited
Loading

Some button without link could not be clicked :

image
image

I think we can add <button> , <xxx class="btn xxxx"></xxx>, <xxx class="button xxx"></xxx> to clickable list .

Futher, we may support different framework's clickable element, such as element with attribute data-toggle="xxx" or someting else . This can be added as extention of vimium .
@eromoe eromoe changed the title Make class="btn" clickable Make class="btn" clickable / Or support clickable css rule extention Apr 28, 2020
@eromoe
Copy link
Author

eromoe commented Apr 28, 2020

Related to #3536, #3049

@eromoe eromoe mentioned this issue Apr 29, 2020
Open
ScottWilliamAnderson added a commit to ScottWilliamAnderson/vimium that referenced this issue Oct 29, 2024
@ScottWilliamAnderson
Fix clickable elements with class 'btn'
4656c1c 
Fixes philc#3550

Update `content_scripts/link_hints.js` to make elements with class 'btn' clickable.

* Add logic to `getLocalHintsForElement` to check for class 'btn' and mark elements as clickable.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/philc/vimium/issues/3550?shareId=XXXX-XXXX-XXXX-XXXX).
Closed
@philc
Copy link
Owner

philc commented Jan 21, 2025

Closing because I don't think this is needed; see discussion on #4566. Feel free to reopen with the URLs of current pages where this would apply.

@philc philc closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clickable elements with class 'btn' ScottWilliamAnderson/vimium
2 participants
@philc @eromoe