Drop special casing for IIS to cover TLS protocol error #17863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had been introduced to fix bug 23220[1], although it is not even clear that IIS caused the problem (some comments mention that this happened with Apache).
Anyhow, in hindsight it seems to be a bad idea to brush warnings about improper implementation of the TLS protocol under the carpet; if a server does not properly implement TLS, users should be aware of that, and report that to the respective developers.
[1] https://bugs.php.net/bug.php?id=23220
The remaining
ERR_get_error() != 0
condition is also somehow fishy; it was supposed to be a fix for https://bugs.php.net/bug.php?id=41770, but the OP claimed it wouldn't fix their issue. And even more confusing: that check is in a branch that is only executed ifERR_peek_error() == 0
, so the warning appears to be unreachable.And from the OpenSSL 1.1.1 documentation;