Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to complete available options #3

Open
przepompownia opened this issue Jun 1, 2020 · 5 comments
Open

Allow to complete available options #3

przepompownia opened this issue Jun 1, 2020 · 5 comments

Comments

@przepompownia
Copy link

Before a while I noticed that the indexer scans files within ./var so I went to exclude it. Before I saw that I can pass configuration. It is good thing but still requires browsing the documentation.

We could expose all available options in suggestions. It seems to be possible:
image
https://github.com/neoclide/coc-tsserver/blob/master/package.json#L142

Exposing all options (reasonable in this context) allow make it more user-friendly and show the power of whole tool.

I wanted to make PR with any working example but I did not found how to add coc-phpactor as a node module with sources within extensions directory.

@dantleech
Copy link
Contributor

Yes - we can do that - but - the problem is that there are lots of them.

I would only add the most common options here (e.g. the include/exclude paths etc). We can now also generate the schema (the documentation is generated). But that requires more thought again.

@dantleech
Copy link
Contributor

Apparently you can add the extension to the RTP and it should just work (I haven't tried it, I actually just edited it in the extensions directory and copied it to the repo 👀 ).

For vscode I just symlinked the repository to .vscode/extensions - maybe something similar also works.

@dantleech
Copy link
Contributor

Phpactor now ships with phpactor.schema.json which could be used to generate the configuration here, the problem would be ensuring that it remains in sync

@przepompownia
Copy link
Author

I dropped using CoC about year ago and no one else is interested in it here so let's close this issue.

@dantleech
Copy link
Contributor

I think it's still valid if somebody wanted to pick up maintainence of this

@dantleech dantleech reopened this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants