Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Nx to the project #36

Merged
merged 4 commits into from
May 6, 2022
Merged

feat: add Nx to the project #36

merged 4 commits into from
May 6, 2022

Conversation

adam-arold
Copy link
Member

  • .lintstagedrc doesn't filter for anything now because eslint / prettier checking would mess with the changes and this PR aims add NX only. I'll re-add the filter in the next PR where I will run prettier --write for the project to prevent further formatting problems
  • The ui components were moved to the libs/shared folder and now it has the util- prefix (nx recommended naming scheme)
  • The script folder was added, this contains scripts for commonly run tasks like build and serve
  • Most configs (tsconfig, prettier, eslint) were moved to the root. The subpackages refer to these as defaults
  • In the backend project:
    • index.ts files were added to gather all exported modules in the project root.
    • The unused mocks folders were removed.
    • The imported .json files were moved to .ts files to add proper typings
  • output.css is not generated when the ui components lib is built, we need to figure out how to get it to work with rollup
  • A global .storybook configuration was added to be used in all projects using storybook

@vercel
Copy link

vercel bot commented May 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
monorepo ❌ Failed (Inspect) May 6, 2022 at 1:09PM (UTC)

@jordaniza
Copy link
Collaborator

Main comment is switch npm scripts to yarn unless there is any reason not to. Npx is probably OK.

@adam-arold
Copy link
Member Author

Main comment is switch npm scripts to yarn unless there is any reason not to. Npx is probably OK.

I removed the package.json file.

@adam-arold adam-arold merged commit 94ea908 into backend May 6, 2022
@adam-arold adam-arold deleted the feature/nx-refactor branch May 6, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants