Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicHTMLVisitor >> visitBold: aBoldText #934

Open
matijakljajic opened this issue Feb 18, 2025 · 2 comments
Open

MicHTMLVisitor >> visitBold: aBoldText #934

matijakljajic opened this issue Feb 18, 2025 · 2 comments

Comments

@matijakljajic
Copy link

This method creates <strong> instead of the <b> tag. The Foliage Visitor uses <b>.

I'm creating an issue instead of a PR because I don't know what was in mind here.
For the Italics Visitor, you create the <i> tag instead of the <em> tag.

As it currently isn't consistent, it all depends if we want to have stylistic or semantic tagging?

I believe that <strong> and <em> would be more semantically correct for HTML generation type of system instead of <b> and <i> as semantics and style should, in theory at least, be separate.

@Ducasse
Copy link
Contributor

Ducasse commented Feb 18, 2025

good remark
Thanks matija.

@Ducasse
Copy link
Contributor

Ducasse commented Feb 18, 2025

I wonder what could be impact on CSS. else I would prefer a semantic marking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants