New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_execution_time parameter for sync diff inspector #844

Open

zph opened this issue Jan 31, 2025 · 0 comments · May be fixed by #845

zph commented Jan 31, 2025 •

edited

Loading

Feature Request

Is your feature request related to a problem? Please describe:

We enforce cluster max_execution_time as a safety mechanism at 30s and find that sync diff inspector needs longer runtimes to avoid experiencing errors due to canceled requests.
This patch allows for setting a different session level max_execution_time value to override the cluster global value.
It maintains the default behavior (no session level limit) unless an additional new argument is provided to sync-diff-inspector

Describe the feature you'd like:

Session level override for max_execution_time

Describe alternatives you've considered:

No good ones came to mind and would require relaxing our reliability stance.

Teachability, Documentation, Adoption, Migration Strategy:

N/A, upgrade and use argument

Filing follow up PR using the patch we run in production.

zph linked a pull request

that will close this issue

Allow max-execution-time parameter for SyncDiffInspector #845

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment