Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade pebble to support build on loong64 #59052

Merged
merged 2 commits into from
Jan 21, 2025
Merged

*: upgrade pebble to support build on loong64 #59052

merged 2 commits into from
Jan 21, 2025
+34 −18

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #59051

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 21, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2025
Benjamin2037
Benjamin2037 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 02:41:19.866185676 +0000 UTC m=+148607.197105082: ☑️ agreed by lance6716.
  • 2025-01-21 02:42:27.427651757 +0000 UTC m=+148674.758571160: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, CbcWestwolf, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,CbcWestwolf,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
@hawkingrei
Copy link
Member

/retest

1 similar comment
@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 21, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5863%. Comparing base (c34a6b6) to head (91fff63).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59052        +/-   ##
================================================
+ Coverage   72.9965%   73.5863%   +0.5897%     
================================================
  Files          1683       1683                
  Lines        465963     467137      +1174     
================================================
+ Hits         340137     343749      +3612     
+ Misses       104867     102470      -2397     
+ Partials      20959      20918        -41
Flag Coverage Δ
integration 42.9391% <ø> (?)
unit 72.3522% <ø> (+0.1691%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4710% <ø> (+0.1599%) ⬆️

@hawkingrei
Copy link
Member

/retest

1 similar comment
@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 21, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 5963b06 into pingcap:master Jan 21, 2025
23 of 24 checks passed
@D3Hunter D3Hunter deleted the upgrade-pebble branch January 21, 2025 09:06
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 21, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #59099.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 21, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 21, 2025
@ti-chi-bot
*: upgrade pebble to support build on loong64 (#59052) (#59099)
541875e 
close #59051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support build on loong64 arch
6 participants
@D3Hunter @hawkingrei @ti-chi-bot @lance6716 @Benjamin2037 @CbcWestwolf